fix: importing unscoped style between multiple sfc's#612
Open
Kolobok12309 wants to merge 7 commits intovitejs:mainfrom
Open
fix: importing unscoped style between multiple sfc's#612Kolobok12309 wants to merge 7 commits intovitejs:mainfrom
Kolobok12309 wants to merge 7 commits intovitejs:mainfrom
Conversation
commit: |
davidglezz
reviewed
Jul 23, 2025
packages/plugin-vue/src/main.ts
Outdated
| async (acc, { scoped, src }, index) => { | ||
| const prevRes = await acc | ||
|
|
||
| if (~prevRes) return prevRes |
There was a problem hiding this comment.
Suggested change
| if (~prevRes) return prevRes | |
| if (prevRes !== -1) return prevRes |
is more readable.
the same to ~foundIndex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes when you import same css (not scoped) file between multiple sfc's you get error while build #5977, #8660
[vite:vue] Cannot read properties of undefined (reading 'scoped')It not very stable error, in out project we only get it in docker, but all be fine on local machine
Reproduce repo from my local machine
Additional context
Multiple descriptors try attach to same filename and style tag can has another index. I fix index to first descriptor and don't reassign it. But finding of index is not so good code
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).