Open
Conversation
Collaborator
|
we, uutils, use codspeed could you please copy what is done with coreutils ? |
Contributor
|
CodSpeed does not count some syscalls. How about your suggestion? |
Author
|
@sylvestre : I am not sure what you mean by "copy". Could you please elaborate. I just migrated to codspeed criterion drop-in replacement. But would you like me to drop Criterion and use the divan benchmark instead? At this early stage this would not be too hard. |
Collaborator
|
yes, please use divan |
Author
|
I removed Criterion and migrated the tests to Divan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development it is often helpful to be able to quickly benchmark the recent changes.
Criterion offers the ability to bench single functions.
This PR introduces criterion and has benches for the parsers (negligible) and cmp compare.
Has also a support function to generate large files to compare for bench-marking.