Skip to content

Improve error message for issue #618 #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltratt merged 1 commit into from
Mar 4, 2026
Merged

Improve error message for issue #618 #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lrpar/src/lib/ctbuilder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,7 +1459,20 @@ where
for i in 0..grm.prod(pidx).len() {
let argt = match grm.prod(pidx)[i] {
Symbol::Rule(ref_ridx) => {
str::parse::<TokenStream>(grm.actiontype(ref_ridx).as_ref().unwrap())?
if let Some(action_type) = grm.actiontype(ref_ridx).as_ref() {
str::parse::<TokenStream>(action_type)?
} else {
let mut s = String::from("\n");
let rule_span = grm.rule_name_span(ref_ridx);
s.push_str(&diag.file_location_msg("Error", Some(rule_span)));
s.push_str("\n");
s.push_str(&diag.underline_span_with_text(
rule_span,
"Rule missing action type".to_string(),
'^',
));
return Err(ErrorString(s).into());
}
}
Symbol::Token(_) => {
let lexemet =
Expand Down Expand Up @@ -1530,6 +1543,8 @@ where
let inner_span =
Span::new(span.start() + last + off + "$".len(), span.end());
let mut s = String::from("\n");
s.push_str(&diag.file_location_msg("Error", Some(inner_span)));
s.push_str("\n");
s.push_str(&diag.underline_span_with_text(
inner_span,
"Unknown text following '$'".to_string(),
Expand Down