Add span information for action code, improve errors.#625
Merged
ltratt merged 1 commit intosoftdevteam:masterfrom Mar 3, 2026
Merged
Add span information for action code, improve errors.#625ltratt merged 1 commit intosoftdevteam:masterfrom
ltratt merged 1 commit intosoftdevteam:masterfrom
Conversation
This adds span information for rust action code in yacc files to the ast. This subsequently gets added to `YaccGrammar` then used for an error message in `CTParserBuilder`.
Member
|
This looks like a good start -- thanks! |
ratmice
added a commit
to ratmice/grmtools
that referenced
this pull request
Mar 3, 2026
This was referenced Mar 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds span information for rust action code in yacc files to the ast. This subsequently gets added to
YaccGrammarthen used for an error message inCTParserBuilder.This is kind of just a first attempt, not a full audit of errors in
CTParserBuilder.I did some light testing by modifying the calc_actions example, but it'd be good to test with a real world example.
Note: I did have to do a clean rebuild of this because it changes the bincode encoding of the
YaccGrammarstruct