[stubtest] Fix false positives for type[TypeVar] defaults#20950
Open
emmanuel-ferdman wants to merge 2 commits intopython:masterfrom
Open
[stubtest] Fix false positives for type[TypeVar] defaults#20950emmanuel-ferdman wants to merge 2 commits intopython:masterfrom
emmanuel-ferdman wants to merge 2 commits intopython:masterfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
While working on
django-stubsI find out that stubtest was reporting false positives when checking default values for parameters typed astype[TypeVar]. Classes with custom metaclasses (like ABC, Enum, or Django models) would fail because stubtest fell back to comparing metaclass types instead of the class itself. This PR also fixes a related issue where type context wasn't propagated to tuple elements, causingtuple[type[list[_T]], ...]to fail with a(list,)default.Example 1:
Output before fix:
Example 2:
Output before fix:
Fixes #13316
Fixes #19852