gh-145566: Skip stop-the-world when reassigning __class__ on newly created objects (gh-145567)#145567
Merged
colesbury merged 2 commits intopython:mainfrom Mar 6, 2026
Merged
Conversation
…newly created objects
mpage
requested changes
Mar 5, 2026
Contributor
mpage
left a comment
mpage
left a comment
There was a problem hiding this comment.
Whoops, was a little too quick too accept. The failing tests look like real failures.
|
When you're done making the requested changes, leave the comment: |
mpage
approved these changes
Mar 5, 2026
colesbury
changed the title
__class__ on newly created objects__class__ on newly created objects (gh-145567)
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @colesbury, I could not cleanly backport this to |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Mar 6, 2026
…__` on newly created objects (pythongh-145567) (cherry picked from commit 1d091a3) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-145601 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__class__on a uniquely owned instances #145566