gh-143055: Fix crash in AST unparser when unparsing dict comprehension unpacking#145556
Open
StanFromIreland wants to merge 4 commits intopython:mainfrom
Open
gh-143055: Fix crash in AST unparser when unparsing dict comprehension unpacking#145556StanFromIreland wants to merge 4 commits intopython:mainfrom
StanFromIreland wants to merge 4 commits intopython:mainfrom
Conversation
StanFromIreland
requested review from
AA-Turner,
Eclips4,
JelleZijlstra,
hugovk,
isidentical and
tomasr8
as code owners
| eq("{**x for x in ()}") | ||
| eq("[(x, y) for x, y in (a, b)]") | ||
| eq("[(x,) for x, in (a,)]") | ||
| eq("Python3 > Python2 > COBOL") |
Member
There was a problem hiding this comment.
Would you mind adding tests for the corresponding case with list comprehensions too?
>>> from __future__ import annotations
>>> def f(x: [*x for x in y]): pass
...
>>> f.__annotations__
{'x': '[*x for x in y]'}
It seems to work correctly already but we should test it explicitly.
Member
Author
|
Something broke with the CI:-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by OSS Fuzz in #489790200.