gh-139759: Add test_unclosed_interpreter_on_fork#145545
Open
aurelwildfellner wants to merge 1 commit intopython:mainfrom
Open
gh-139759: Add test_unclosed_interpreter_on_fork#145545aurelwildfellner wants to merge 1 commit intopython:mainfrom
aurelwildfellner wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a unit test which covers the issue raced in gh-139759 - forking when a subinterpreter is not properly closed creates a segfault in the child process.
Note, currently this test will fail. I provide it to emphasize the existing issue and as something to add to the testsuite once there is a proper fix.
The thread state handling is a bit intriguing to me, so I will propably not work on an actual fix. But maybe it is useful to someone actually picking up the issue.