gh-145272: Fix data race when accessing func_code in PyFunctionObject#145534
Open
Krishna-web-hub wants to merge 1 commit intopython:mainfrom
Open
gh-145272: Fix data race when accessing func_code in PyFunctionObject#145534Krishna-web-hub wants to merge 1 commit intopython:mainfrom
Krishna-web-hub wants to merge 1 commit intopython:mainfrom
Conversation
Krishna-web-hub
force-pushed
the
New_fix_clean
branch
from
d7c99b0 to
d926271
Compare
vstinner
reviewed
Mar 5, 2026
| } | ||
|
|
||
| return Py_NewRef(op->func_code); | ||
| PyCodeObject *code = _Py_atomic_load_ptr(&op->func_code); |
Member
There was a problem hiding this comment.
Would it be possible to use PyFunction_GET_CODE() and fix PyFunction_GET_CODE() to use an atomic operation?
Maybe also only use atomic operation if the Py_GIL_DISABLED macro is defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a data race when accessing PyFunctionObject.func_code in free-threaded builds.
This patch replaces the direct read with
_Py_atomic_load_ptr()and updates the setter to use_Py_atomic_exchange_ptr()so that updates tofunc_codeare performed atomically.The race was reproduced using
ThreadSanitizerand verified to be fixed after this change.func_set_code#145272