Skip to content

gh-145055: Accept frozendict for globals in exec() and eval()#145072

Merged
vstinner merged 4 commits intopython:mainfrom
vstinner:frozendict_globals
Mar 5, 2026
Merged

gh-145055: Accept frozendict for globals in exec() and eval()#145072
vstinner merged 4 commits intopython:mainfrom
vstinner:frozendict_globals

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 21, 2026

@vstinner
Copy link
Member Author

vstinner commented Mar 3, 2026

The PR is now ready for review.

@vstinner
Copy link
Member Author

vstinner commented Mar 3, 2026

cc @skirpichev

@skirpichev skirpichev self-requested a review March 3, 2026 11:40
@vstinner
Copy link
Member Author

vstinner commented Mar 3, 2026

It's still possible to modify builtins, unless builtins is declared as a frozendict:

# module __builtins__
>>> fd=frozendict(__builtins__=__builtins__)
>>> exec("__builtins__.x = 1", fd, fd)

# dict __builtins__
>>> fd=frozendict(__builtins__=__builtins__.__dict__)
>>> exec("__builtins__['x'] = 1", fd, fd)

# frozendict __builtins__
>>> fd=frozendict(__builtins__=frozendict(__builtins__.__dict__))
>>> exec("__builtins__['x'] = 1", fd, fd)
Traceback (most recent call last):
  ...
TypeError: 'frozendict' object does not support item assignment

@vstinner vstinner requested a review from FFY00 as a code owner March 4, 2026 09:41
@vstinner
Copy link
Member Author

vstinner commented Mar 4, 2026

@skirpichev: I removed the sentence from the documentation, and I replaced it with a more precise error message if assigning __builtins__ to the frozendict globals fails. Please review the updated PR.

@skirpichev skirpichev self-requested a review March 4, 2026 10:51
@vstinner vstinner merged commit c0ecf21 into python:main Mar 5, 2026
54 checks passed
@vstinner vstinner deleted the frozendict_globals branch March 5, 2026 11:35
@vstinner
Copy link
Member Author

vstinner commented Mar 5, 2026

Merged. Thanks for the review @skirpichev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants