Conversation
| if (length(keys) == 0) { | ||
| message("No active jobs found.") | ||
| return(vctrs::vec_ptype(connectapi_ptypes$job_termination)) | ||
| return(tibble::tibble()) |
There was a problem hiding this comment.
This looks wrong, though I guess if there are no jobs it would return nothing...
|
I have a WIP branch to do something similar that I hadn't gotten opened yet, let me open a PR to compare. I think there are some pros/cons of each |
Opened #513 |
I like the approach you have there and am very happy to defer to you on this! The approaches overall are very similar, and both achieve a good amount of code deletion + simplification and flexibility |
2 participants
Intent
Remove the strict type checking. This is basically a oneshot from claude. Putting up here to see if CI passes + what folks think
Approach
Only to coercion around date times since we get RFC 3339 back which are not auto-converted to
posix.ct(though maybe we don't even need to do that, just accept these are characters and then only at presentation / dataframing do we make them a native type.Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?