fix: flatten outputs before building loadingOutputs#3641
Open
i-murray wants to merge 1 commit intoplotly:devfrom
Open
fix: flatten outputs before building loadingOutputs#3641i-murray wants to merge 1 commit intoplotly:devfrom
i-murray wants to merge 1 commit intoplotly:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
dcc.Loadingspinner not triggering when a callbackOutputuses theALLwildcard.Problem
In
dash-renderer/src/actions/callbacks.ts,loadingOutputswas built withoutputs.map(...). When the output spec containsALL,unwrapIfNotMultireturns resolved outputs as a nested array. Iterating with.map()over this nested structure meantout.idwasundefined, sogetPathreturnedundefinedand the loading reducer never matched the component path.Fix
Changed
outputs.map(...)toflatten(outputs).map(...)on L794, consistent with how outputs are already flattened on L829 and L912 in the same function.Fixes #3619