Skip to content

markdown-translator: post-process GitHub mention links after JA translation#23

Merged
shhdgit merged 5 commits intopingcap:mainfrom
qiancai:fix-github-mention-postprocess
Mar 6, 2026
Merged

markdown-translator: post-process GitHub mention links after JA translation#23
shhdgit merged 5 commits intopingcap:mainfrom
qiancai:fix-github-mention-postprocess

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 5, 2026

Fix pingcap/docs#22519
Related PR: #21

Summary

  • add a markdown translator post-process step to normalize GitHub profile mention links
  • apply replacement in JA translation entries after translation completes
  • add tests for content-level replacement and file in-place processing

Replacement rule

  • from: @\s*\[[^\]]*\]\(https?:\/\/github\.com\/([^)\s\/]+)\/?\)
  • to: @[$1](http://github.com/$1)

Why

This avoids translated Japanese display text in GitHub mention links and keeps mentions as stable GitHub IDs.

@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Mar 5, 2026

CLA assistant check
All committers have signed the CLA.

@qiancai qiancai force-pushed the fix-github-mention-postprocess branch from e0b08de to 6d0b631 Compare March 5, 2026 11:06
@qiancai qiancai changed the title markdown-translator: post-process GitHub mention links after translation markdown-translator: post-process GitHub mention links after JA translation Mar 5, 2026
@qiancai qiancai requested a review from shhdgit March 6, 2026 01:20
@shhdgit shhdgit merged commit 44b2068 into pingcap:main Mar 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub IDs are unexpectedly translated in Japanese docs

2 participants