Conversation
jpuzz0
reviewed
Mar 4, 2026
|
|
||
| console.log(`🚀 Deploying "${distDir}" to GitHub Pages (branch: ${branch})...`); | ||
| await execa('npx', ['gh-pages', '-d', distDir, '-b', branch], { | ||
| cwd, |
Collaborator
There was a problem hiding this comment.
Since gh-pages isn't in package.json, this downloads it fresh every time via npx. Should it be a direct dependency instead?
| throw new Error( | ||
| `Build output directory "${distDir}" does not exist. Run a build first or specify the correct directory with -d/--dist-dir.` | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
If someone passes an absolute path for --dist-dir, would path.join here do the right thing? path.resolve might be safer.
| throw new Error( | ||
| 'This directory is not a git repository. Initialize with "git init" or use "patternfly-cli init", and ensure the repo has a remote (e.g. GitHub) before deploying.' | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
save.ts checks for an origin remote before pushing — should this do the same? Without it, gh-pages will fail with a pretty cryptic git error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to deploy to github pages. Close issue #8