Skip to content

RequestFactory: simplified#31

Open
JanTvrdik wants to merge 2 commits intonette:masterfrom
JanTvrdik:request_factory_simplified2
Open

RequestFactory: simplified#31
JanTvrdik wants to merge 2 commits intonette:masterfrom
JanTvrdik:request_factory_simplified2

Conversation

@JanTvrdik
Copy link
Contributor

  • removes URL filters which are very rarely used and could be implemented in userland
  • removes $_SERVER['ORIG_PATH_INFO'] because I don't know any HTTP server used in real-world which would actually require this

@hrach
Copy link
Contributor

hrach commented Dec 17, 2014

+1 never used it.

@JanTvrdik
Copy link
Contributor Author

I also did not manage to find a server where $_SERVER['SCRIPT_NAME'] would be undefined.

@JanTvrdik
Copy link
Contributor Author

@dg Can I remove the URL filters? They are magical and people who know about them prefer to turn them off anyway – see http://forum.nette.org/cs/9903-ne-kanonizace-lomitek-v-url or https://twitter.com/JanTvrdik/status/542389794085404673 Or does it fall into the same category as binary mode?

@dg
Copy link
Member

dg commented Dec 20, 2014

ad $_SERVER['ORIG_PATH_INFO'] & $_SERVER['SCRIPT_NAME']: detection is magic. See this versus this. Currently it somehow works and it is better to not touch it ;-)

ad filters: their problem is that they do not work with canonicalization… Filters are not used because nobody knows about them, they are hard to set, but they are useful. For example, they fix bad url parsers (like this), so it would be better to figure out how to solve the canonicalization.

dg added a commit that referenced this pull request Dec 26, 2014
dg added a commit that referenced this pull request Dec 26, 2014
dg added a commit that referenced this pull request Dec 27, 2014
dg added a commit that referenced this pull request Dec 27, 2014
…PT_FILENAME (BC break)

see #31

Conflicts:
	src/Http/RequestFactory.php
@dg
Copy link
Member

dg commented Dec 27, 2014

Partially merged by 37971f0

@dg dg force-pushed the master branch 4 times, most recently from e6f0643 to d6d5cc2 Compare December 27, 2014 04:21
@JanTvrdik
Copy link
Contributor Author

ad filters: I'm aware of what they can do, I'm just saying that nobody is using them for that. Even your websites don't use them. Wouldn't it be better to handle those use-cases in routing instead of RequestFactory? Or not handle them at all?

@dg dg force-pushed the master branch 3 times, most recently from 0bb4336 to 96b498c Compare December 27, 2014 07:22
@dg dg force-pushed the master branch 2 times, most recently from 6df6a37 to f17b437 Compare February 9, 2015 23:14
@dg dg force-pushed the master branch 4 times, most recently from f3ed3a1 to f09472f Compare November 4, 2015 21:42
@dg dg force-pushed the master branch 14 times, most recently from b551857 to 2f83ae4 Compare January 26, 2017 01:23
@dg dg force-pushed the master branch 3 times, most recently from 8b74ce7 to 86c9227 Compare February 2, 2017 00:54
@dg dg force-pushed the master branch 2 times, most recently from 7f12fde to 9791354 Compare February 10, 2017 12:57
@dg dg force-pushed the master branch 2 times, most recently from 51f373c to 69af026 Compare June 13, 2017 09:59
@dg dg force-pushed the master branch 3 times, most recently from 87fefb5 to 9590f91 Compare July 21, 2017 19:42
@dg dg force-pushed the master branch 4 times, most recently from 56c2641 to 544d9e6 Compare March 14, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants