Skip to content

LinkGenerator: allow semicolon destination prefix#256

Open
dakujem wants to merge 25 commits intonette:masterfrom
dakujem:feat/trim-semicolon-prefixed-links-in-link-generator
Open

LinkGenerator: allow semicolon destination prefix#256
dakujem wants to merge 25 commits intonette:masterfrom
dakujem:feat/trim-semicolon-prefixed-links-in-link-generator

Conversation

@dakujem
Copy link

@dakujem dakujem commented Mar 24, 2020

Allows passing semicolon-prefixed destinations to LinkGenerator::link calls:

(new LinkGenerator(...))->link(':Foo:Bar:baz');
(new LinkGenerator(...))->link(':Bar:baz');

// and also this:
(new LinkGenerator(...))->link($presenter->getAction(true));

--
closes #255

@dg dg force-pushed the master branch 3 times, most recently from e23d6da to 22d5246 Compare March 25, 2020 10:45
@dakujem dakujem force-pushed the feat/trim-semicolon-prefixed-links-in-link-generator branch from 4d7947a to 82ad558 Compare March 25, 2020 17:09
@dakujem
Copy link
Author

dakujem commented Mar 25, 2020

@dg I'd be grateful if this was merged & released promptly. It would be awesome. I see praparations for next release. This should be fully compatible.

@dg dg force-pushed the master branch 11 times, most recently from 4aeacfd to 06a6513 Compare April 2, 2020 00:57
@dg dg force-pushed the master branch 3 times, most recently from 3b21865 to 548c1db Compare April 20, 2020 21:58
@dg dg force-pushed the master branch 3 times, most recently from 18efdae to 3f51018 Compare May 11, 2020 22:55
@dakujem
Copy link
Author

dakujem commented May 20, 2020

Should I rebase this? Any plan to fix the issue?

@dakujem dakujem force-pushed the feat/trim-semicolon-prefixed-links-in-link-generator branch from 82ad558 to b293b75 Compare May 20, 2020 19:17
@dakujem
Copy link
Author

dakujem commented May 20, 2020

You should update your test config - PHP 7.1 is no longer your target.

@dakujem dakujem force-pushed the feat/trim-semicolon-prefixed-links-in-link-generator branch from b293b75 to 6f03449 Compare May 28, 2020 12:52
@dg dg force-pushed the master branch 2 times, most recently from ef333e6 to 9d529b4 Compare June 9, 2020 12:55
@dg dg force-pushed the master branch 2 times, most recently from 16b95e3 to 8cd3f23 Compare October 15, 2020 22:02
@dg dg force-pushed the master branch 13 times, most recently from ac00a63 to 51b4fd3 Compare November 2, 2020 15:21
@dg dg force-pushed the master branch 7 times, most recently from dd9abb3 to ed0d1c4 Compare November 9, 2020 11:22
@dg dg force-pushed the master branch 3 times, most recently from ea5ac15 to 0e37ebd Compare November 16, 2020 01:42
@dg dg force-pushed the master branch 2 times, most recently from af99b74 to ad60129 Compare November 25, 2020 18:17
@dg dg force-pushed the master branch 3 times, most recently from cfac883 to 45d9ace Compare December 17, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported semicolon prefix in LinkGenerator::link calls

3 participants