Presenter::$layout can be either string or null#233
Open
mabar wants to merge 1 commit intonette:masterfrom
Open
Presenter::$layout can be either string or null#233mabar wants to merge 1 commit intonette:masterfrom
mabar wants to merge 1 commit intonette:masterfrom
Conversation
dg
force-pushed
the
master
branch
7 times, most recently
from
7e42997 to
f7df426
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
0e26720 to
e65cf05
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
7fe78c1 to
8f1bb54
Compare
dg
force-pushed
the
master
branch
13 times, most recently
from
c8eff84 to
447af2d
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
4317004 to
178b74c
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
84cecc4 to
da24ae5
Compare
dg
force-pushed
the
master
branch
15 times, most recently
from
95a824c to
049d171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not really
string|boolbutstring|false|null, which kinda surprised me when I was implementing own layout finderThis variant is the only one I found which simplifies problem and does not break default implementation. Not sure about custom ones.
Alternative variant is change of annotation to
string|false|null, but it's ugly.