Added presenter mapper#16
Conversation
|
I am not sure that own mapper is really needed. I agree that mapping can be enhanced for |
|
I for one would use such mapper. It really enables modularity across packages and default implementation can be reused as a fallback for custom implementation. Now I can have multiple packages sharing same <?php $mapping = [ 'shop' => [
'packageA/src/Shop/Presenters',
'packageB/src/Shop/Presenters',
// ...
] ]For now I have to prefix each package, because using multiple directories for same |
|
👍 |
|
I think that use |
|
@matej21 you are rigth. I removed |
|
👍 for this |
|
👍 I like it. |
There was a problem hiding this comment.
I think we should keep this method for BC purposes and just alias it to $this->presenterMapper->formatPresenterClass(...).
|
What is purpose of this PR? To add What is the advantage of "split" 2-methods IPresenterFactory into 2-methods IPresenterFactory plus 2-methods IPresenterMapper? Is there really such big need to create your own mappers? |
c6ea262 to
7fc9a04
Compare
d4f8f8f to
b9ada7c
Compare
ab57645 to
3386bd1
Compare
b7c910a to
3f30cee
Compare
b9d4eb3 to
8ca92c7
Compare
18f376d to
3fe619f
Compare
20a93ca to
08cbdeb
Compare
2c1ae3b to
b42b3fe
Compare
bc2dfc2 to
8f2b6ff
Compare
|
Seems legit. What needs to be done here? |
Discusion: http://forum.nette.org/en/19620-better-mapping-configuration#p135799
For easier use custom mapping implementation
with nette/bootstrap#8