Conversation
natoverse
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow profiling for txt:
Findings:
For the NLP pipeline, threading would not provide any benefit anyway, since spaCy and TextBlob are CPU‑bound and constrained by the GIL. We therefore removed the unused threading logic from build_noun_graph and replaced it with a straightforward sequential loop. This matches the real execution behavior prior to the change, while reducing overhead and lowering memory usage.
This pull request refactors and enhances the NLP-based graph extraction workflow to support streaming results directly into output tables, improving scalability and efficiency. The main changes include updating the workflow to process data using storage tables instead of dataframes, implementing streaming writes for entities and relationships, and restructuring the graph extraction logic for better performance and maintainability.
Workflow and API changes:
extract_graph_nlpworkflow now processes data usingTableobjects for text units, entities, and relationships, enabling more efficient handling of large datasets and streaming output. [1] [2]Graph extraction logic improvements:
build_noun_graph.py) is refactored to operate on storage tables, with improved async batching and progress logging, and more efficient node and edge construction.General updates: