FR: Add Hop Limits to send functions#828
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an optional hop-limit override to several high-level “send” helper methods in MeshInterface, allowing callers to control routing TTL per message while still delegating packet construction/sending to sendData() / _sendPacket().
Changes:
- Add optional
hopLimitparameter tosendText(),sendAlert(),sendPosition(),sendTelemetry(),sendWaypoint(), anddeleteWaypoint(). - Forward
hopLimitthrough tosendData()so it ultimately setsmeshPacket.hop_limitin_sendPacket(). - Update docstring for
sendText()and partially forsendAlert()to mentionhopLimit.
| Arguments: | ||
| text {string} -- The text of the alert to send | ||
| hopLimit -- hop limit to use | ||
|
|
There was a problem hiding this comment.
In this docstring, hopLimit is listed under “Arguments”, but it’s a keyword argument (optional) in the function signature. Move it to the “Keyword Arguments” section (or clarify it’s optional) to avoid misleading API docs.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #828 +/- ##
==========================================
+ Coverage 59.99% 60.59% +0.59%
==========================================
Files 24 24
Lines 4267 4337 +70
==========================================
+ Hits 2560 2628 +68
- Misses 1707 1709 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.