Conversation
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Summary of ChangesHello @Katotodan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Figma invite link embedded within several GitHub issue templates. The change ensures that any user or contributor referencing these templates will be directed to the correct and active Figma design collaboration environment, improving the accuracy of external resource links and streamlining access to design assets. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Figma invite link across multiple issue template files. The change is straightforward and applied consistently. My review includes one suggestion to improve the long-term maintainability of these templates by centralizing repeated links. This would prevent the need for multi-file updates for a single link change in the future.
| - Meshery documentation [site](https://docs.meshery.io/) and [source](http://github.com/meshery/meshery/tree/master/docs) | ||
| - 🛠 [Meshery Build & Release Strategy](https://docs.meshery.io/project/contributing/build-and-release) | ||
| - 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/qJy1c95qirjgWQODApilR9) | ||
| - 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/GvB8SudhEOoq3JOvoLaoMs) |
There was a problem hiding this comment.
While the link update is correct, this change highlights a maintainability issue. The same Figma link is hardcoded in at least six different issue templates. This requires updating multiple files for a single change, as seen in this PR.
To improve maintainability and adhere to the Don't Repeat Yourself (DRY) principle, I recommend centralizing common links. You could place them in a dedicated section of a file like CONTRIBUTING.md or a new .github/RESOURCES.md file. The issue templates could then link to this central location. This would make future updates much simpler and less error-prone.
Notes for Reviewers
Update figma invite link
Signed commits