-
Notifications
You must be signed in to change notification settings - Fork 18
Bridge: RPCManager #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephen-derosa
wants to merge
4
commits into
livekit:main
Choose a base branch
from
stephen-derosa:sderosa/bridge-rpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,403
−113
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
efc737c
Bridge RPC: Mute/unmute working examples with audio/video
stephen-derosa 77ab7bb
requestTrackMute/Unmute -> requestRemoteTrackMute/Unmute . Make the t…
stephen-derosa 3237ad6
clang
stephen-derosa 260ce13
add spdlog to docker and github actions
stephen-derosa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Copyright 2026 LiveKit | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /// @file rpc_constants.h | ||
| /// @brief Constants for built-in bridge RPC methods. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <string> | ||
|
|
||
| namespace livekit_bridge { | ||
| namespace rpc { | ||
|
|
||
| /// Built-in RPC method name used by remote track control. | ||
| /// Allows remote participants to mute, unmute, or release tracks | ||
| /// published by this bridge. Must be called after connect(). | ||
| /// Audio/video tracks support mute, unmute, and release. Data tracks | ||
| /// only support release (they have no mute/unmute); a mute request on | ||
| /// a data track is treated as release, and unmute returns an error. | ||
| namespace track_control { | ||
|
|
||
| enum class Action { kActionMute, kActionUnmute }; | ||
|
|
||
| /// RPC method name registered by the bridge for remote track control. | ||
| constexpr const char *kMethod = "lk.bridge.track-control"; | ||
|
|
||
| /// Payload action strings. | ||
| constexpr const char *kActionMute = "mute"; | ||
| constexpr const char *kActionUnmute = "unmute"; | ||
|
|
||
| /// Delimiter between action and track name in the payload (e.g. "mute:cam"). | ||
| constexpr char kDelimiter = ':'; | ||
|
|
||
| /// Response payload returned on success. | ||
| constexpr const char *kResponseOk = "ok"; | ||
|
|
||
| /// Build a track-control RPC payload: "<action>:<track_name>". | ||
| inline std::string formatPayload(const char *action, | ||
| const std::string &track_name) { | ||
| std::string payload; | ||
| payload.reserve(std::char_traits<char>::length(action) + 1 + | ||
| track_name.size()); | ||
| payload += action; | ||
| payload += kDelimiter; | ||
| payload += track_name; | ||
| return payload; | ||
| } | ||
|
|
||
| } // namespace track_control | ||
| } // namespace rpc | ||
| } // namespace livekit_bridge |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RpcMethod is pretty low level, I wonder if we should make a remote controller, and we will setup a remoteControlInternal method as the communication channel for the remote control