Skip to content

Autocomplete Improvements#63

Merged
rcosta358 merged 17 commits intomainfrom
autocomplete-improvements
Mar 5, 2026
Merged

Autocomplete Improvements#63
rcosta358 merged 17 commits intomainfrom
autocomplete-improvements

Conversation

@rcosta358
Copy link
Collaborator

@rcosta358 rcosta358 commented Feb 26, 2026

This PR improves the autocomplete suggestions by:

  • Not suggesting ghosts/states from different classes (aliases are fine)
  • Implementing annotation-specific suggestions
  • Implementing trigger characters (" and .)
  • Suggesting ghosts/states after this. or old(this).
  • Suggesting parameters in method and parameter level refinements
  • Suggesting the variable we are refining (doesn't work very reliably because of the last point mentioned in the future work section)

Future Work

  • Not suggest return unless we are in a method level refinement (still shows for field refinements)
  • Autocomplete for @ExternalRefinementsFor (similarly to the autocomplete VS Code provides in imports)
  • Have autocomplete work even in the presence of LiquidJava errors (e.g., when an error occurs, subsequent variables are not added to the context and therefore are not suggested)

@rcosta358 rcosta358 self-assigned this Feb 26, 2026
@rcosta358 rcosta358 added the enhancement New feature or request label Feb 26, 2026
@rcosta358 rcosta358 requested review from CatarinaGamboa and removed request for CatarinaGamboa February 26, 2026 00:22
@rcosta358 rcosta358 marked this pull request as draft February 26, 2026 00:23
@rcosta358 rcosta358 marked this pull request as ready for review February 28, 2026 18:49
Copy link
Collaborator

@CatarinaGamboa CatarinaGamboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase first, i think there are some changes in server right? maybe i'm confusing

<version>0.0.13</version>
<scope>system</scope>
<systemPath>${project.basedir}/libs/liquidjava-verifier.jar</systemPath>
</dependency> -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dont we need this? maybe rebase

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left that dependency commented out for testing the verifier locally, where I'd manually build and place the verifier jar in the language server. However, by simply running mvn install in the verifier, the dependency is automatically updated locally, as long as the version numbers match, so it's just unnecessary.

@rcosta358
Copy link
Collaborator Author

The rebase was already performed.

@rcosta358 rcosta358 merged commit 68bc433 into main Mar 5, 2026
@rcosta358 rcosta358 deleted the autocomplete-improvements branch March 5, 2026 14:21
rcosta358 added a commit that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants