Conversation
This is still not perfect because it suggests `return` when we are refining a class field.
Dot and quote trigger characters (dot only triggers for `this` and `old(this)`).
CatarinaGamboa
approved these changes
Mar 5, 2026
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
rebase first, i think there are some changes in server right? maybe i'm confusing
| <version>0.0.13</version> | ||
| <scope>system</scope> | ||
| <systemPath>${project.basedir}/libs/liquidjava-verifier.jar</systemPath> | ||
| </dependency> --> |
Collaborator
There was a problem hiding this comment.
why dont we need this? maybe rebase
Collaborator
Author
There was a problem hiding this comment.
I left that dependency commented out for testing the verifier locally, where I'd manually build and place the verifier jar in the language server. However, by simply running mvn install in the verifier, the dependency is automatically updated locally, as long as the version numbers match, so it's just unnecessary.
Collaborator
Author
|
The rebase was already performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the autocomplete suggestions by:
"and.)this.orold(this).Future Work
returnunless we are in a method level refinement (still shows for field refinements)@ExternalRefinementsFor(similarly to the autocomplete VS Code provides in imports)