feat: classes for inference systems and logical equivalence#398
Open
feat: classes for inference systems and logical equivalence#398
Conversation
chenson2018
reviewed
Mar 4, 2026
Collaborator
chenson2018
left a comment
There was a problem hiding this comment.
Just some nitpicks, I haven't properly thought about the big picture here yet.
Collaborator
Author
|
Should be ok now, but we should merge #393 first. |
Collaborator
I have approved 393 and will take a look at your most recent comments/changes tomorrow. |
Collaborator
|
Holding off approval until the documentation issue mentioned at #CSLib > `Context.fill` notation @ 💬 is resolved, but this all seems fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the beginning of work for formalising general concepts about logic in CSLib, in order to streamline the development of logics. A major challenge is that judgements, proof systems, and semantics can be very different across logics, so we cannot assume any particular shapes for them.
To address this, this PR introduces:
⇓notation for derivations and the associated notion of Derivability.LogicalEquivalences. We formalise a logical equivalence as a congruence on propositions that preserves validity under any judgemental context.Depends on #393 for the new context fill notation.