Conversation
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
|
@leecalcote should i also upgrade mocha version ? please take a look |
| "scripts": { | ||
| "dev": "cross-env NODE_ENV=development webpack-dev-server -d --progress --colors", | ||
| "test": "cross-env NODE_ENV=test mocha --require ./test/babel-register.js --extensions js,jsx test/**/*.test.js", | ||
| "test": "cross-env NODE_ENV=test mocha --require ./test/swc-register.js --extension js --extension jsx test/**/*.test.js", |
There was a problem hiding this comment.
@saurabhraghuvanshii instead of the comma-separated values, i just added it twice, it matches mocha's current cli behavior
kishore08-07
left a comment
There was a problem hiding this comment.
@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6.
Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?
package.json
Outdated
| @@ -107,7 +97,6 @@ | |||
| "dependencies": { | |||
| "@babel/runtime-corejs3": "^7.12.1", | |||
There was a problem hiding this comment.
@YASHMAHAKAL @babel/runtime-corejs3 is still in dependencies. Can we remove this?
There was a problem hiding this comment.
@kishore08-07, i had a reason for this, but i thought on that reason again, and now i think i should be removing it, Thanks.
rollup.config.js
Outdated
| targets: { | ||
| ie: '11', | ||
| chrome: '58', | ||
| firefox: '54', | ||
| safari: '10', | ||
| edge: '15', |
There was a problem hiding this comment.
@YASHMAHAKAL shall we update to modern baselines?
There was a problem hiding this comment.
implemented, this made build even faster.. Thanks !
The different module types are intentional and follow the recommended pattern for Rollup + SWC. |
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
@YASHMAHAKAL Thanks for clarifying, that makes sense. |
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Notes for Reviewers
This PR fixes #
Migrates from Babel to SWC
Signed commits