fix: Make default optional with a disabled config default#97
Merged
jsonbailey merged 4 commits intomainfrom Mar 5, 2026
Merged
fix: Make default optional with a disabled config default#97jsonbailey merged 4 commits intomainfrom
jsonbailey merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
keelerm84
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix!: Rename default_value args to default
Note
Medium Risk
This is a breaking API change for callers using
default_value=keyword arguments, and it changes fallback behavior to implicitly return disabled configs when no default is provided.Overview
API change: Renames config default parameters from
default_valuetodefaultand makes them optional acrosscompletion_config,judge_config,create_chat,create_judge, andagent_config(plus related request types), using a disabled default when omitted.Adds
AIConfigDefault.disabled()(inherited by specific default types) to standardize the disabled fallback behavior, and updates READMEs and tests to reflect the new parameter name and the new “no default provided” behavior.Written by Cursor Bugbot for commit 4446405. This will update automatically on new commits. Configure here.