Skip to content

fix: Make default optional with a disabled config default#97

Merged
jsonbailey merged 4 commits intomainfrom
jb/aic-1628/make-defaults-optional
Mar 5, 2026
Merged

fix: Make default optional with a disabled config default#97
jsonbailey merged 4 commits intomainfrom
jb/aic-1628/make-defaults-optional

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Mar 5, 2026

fix!: Rename default_value args to default


Note

Medium Risk
This is a breaking API change for callers using default_value= keyword arguments, and it changes fallback behavior to implicitly return disabled configs when no default is provided.

Overview
API change: Renames config default parameters from default_value to default and makes them optional across completion_config, judge_config, create_chat, create_judge, and agent_config (plus related request types), using a disabled default when omitted.

Adds AIConfigDefault.disabled() (inherited by specific default types) to standardize the disabled fallback behavior, and updates READMEs and tests to reflect the new parameter name and the new “no default provided” behavior.

Written by Cursor Bugbot for commit 4446405. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey marked this pull request as ready for review March 5, 2026 15:59
@jsonbailey jsonbailey requested a review from a team as a code owner March 5, 2026 15:59
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@jsonbailey jsonbailey merged commit 39e09c6 into main Mar 5, 2026
3 checks passed
@jsonbailey jsonbailey deleted the jb/aic-1628/make-defaults-optional branch March 5, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants