Update UI login test initial/password configs and ingress wait#94
Open
sjd78 wants to merge 2 commits intokonveyor:mainfrom
Open
Update UI login test initial/password configs and ingress wait#94sjd78 wants to merge 2 commits intokonveyor:mainfrom
sjd78 wants to merge 2 commits intokonveyor:mainfrom
Conversation
With konveyor/tackle-ui-tests#1543, it is possible to provide the default admin user password that needs to be changed on first login. While the test configs embed the default username and password, it is useful to explicitly define them in the workflow so we know exactly what is being used. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
e2e_ui_login_tests_update
branch
from
74009e1 to
3cd2be1
Compare
WalkthroughThe Kubernetes ingress readiness check in two GitHub Actions workflows was simplified by replacing manual polling loops with a single Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With konveyor/tackle-ui-tests#1543, it is possible to provide the default admin user password that needs to be changed on first login. While the test configs embed the default username and password, it is useful to explicitly define them in the workflow so we know exactly what is being used.
Use the same ingress wait as http://github.com/konveyor/tackle-ui-tests/blob/6a7e88b54e63d15e122441a2bef1fe123a7a6a7f/.github/workflows/run-ui-tests.yaml#L85-L95
Summary by CodeRabbit