Optimize log filter matching and trigger allocation#6419
Open
incrypto32 wants to merge 2 commits intomasterfrom
Open
Optimize log filter matching and trigger allocation#6419incrypto32 wants to merge 2 commits intomasterfrom
incrypto32 wants to merge 2 commits intomasterfrom
Conversation
Replace all_edges() linear scan with contains_edge() and edge_weight() in matches() and requires_transaction_receipt().
Replace flat_map(...).collect() with explicit loops and a pre-sized Vec to avoid repeated reallocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all_edges() linear scan with contains_edge()/edge_weight() O(1) lookup in EthereumLogFilter::matches() and requires_transaction_receipt().
Replace flat_map(...).collect() with pre-allocated Vec in parse_log_triggers() to eliminate repeated reallocations.
CPU profiling indicated these two paths as hotspots during block processing.