feat: add priorityClassName to the deployment template#683
Open
v-shechenkov wants to merge 3 commits intografana:mainfrom
Open
feat: add priorityClassName to the deployment template#683v-shechenkov wants to merge 3 commits intografana:mainfrom
v-shechenkov wants to merge 3 commits intografana:mainfrom
Conversation
|
|
kworkbee
reviewed
Dec 9, 2025
Contributor
There was a problem hiding this comment.
@v-shechenkov It seems that changes to values.schema.json are also needed to pass the validation.
Author
|
Thanks for spotting it @kworkbee ! Committed changes to schema |
Collaborator
|
Please describe what issue this PR is fixing. Is it a request to add things to the Helm chart? For reference. |
Author
|
Thanks for your recommendations @yorugac ! Made changes according to your comment |
yorugac
requested changes
Dec 19, 2025
Collaborator
yorugac
left a comment
yorugac
left a comment
There was a problem hiding this comment.
Hi @v-shechenkov, thanks for the PR. I have 2 small change requests:
- Please move
priorityClassNametomanagersection, to avoid misunderstanding as to which pods it is affecting. As mentioned in the issue,TestRunpods have separate config ATM. - It'd be good to add a small description for a new field 🙂
Collaborator
|
👋 @v-shechenkov, would you be able to follow-up on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding priorityClassName field to a Helm chart will allow to define Pod deployment priority.
See: #695