C#: Add default taint step from an implicit operator call to its argument.#21400
Draft
michaelnebel wants to merge 3 commits intogithub:mainfrom
Draft
C#: Add default taint step from an implicit operator call to its argument.#21400michaelnebel wants to merge 3 commits intogithub:mainfrom
michaelnebel wants to merge 3 commits intogithub:mainfrom
Conversation
77dbe2c to
c3f0d4a
Compare
c3f0d4a to
cfd4be6
Compare
Contributor
Author
|
@hvitved : Is this an acceptable approach for solving the problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this flow source row:
and this snippet:
On the second line there's a call to operator an implicit conversion which means that
bufferis not an argument towebSocket.ReceiveAsync, but rather an argument to the call to an implicit conversion (which is then an argument toReceiveAsync). However, we would likebufferto be tainted after the call toReceiveAsync.This is solved by adding a reverse update default taint step for post-update nodes for implicit conversion calls.
That is, for
f(implicit_conv(x))we add a step from the post-update ofimplicit_conv(x)tox.