Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/updates Schemars schema helpers so diff-related types export byte-array schemas for BString fields.
Changes:
- Introduces a new
bstring_bytes_optschema helper inbut-schemars. - Updates
DiffSpecschema annotations to use the new helper for byte-oriented path fields.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/but-schemars/src/lib.rs | Adds a new schema helper intended for optional byte-string fields. |
| crates/but-core/src/diff_types.rs | Switches DiffSpec schema annotations to use byte-array schema helpers. |
Caleb-T-Owens
force-pushed
the
fix-diff-types
branch
from
8fba1d2 to
85be404
Compare
krlvi
approved these changes
Mar 5, 2026
Byron
reviewed
Mar 6, 2026
Collaborator
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
I setting this back to draft because something is fishy here, let's clarify before merging.
Caleb-T-Owens
force-pushed
the
fix-diff-types
branch
from
85be404 to
25d60dd
Compare
Caleb-T-Owens
force-pushed
the
fix-diff-types
branch
from
25d60dd to
f5e0a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.