Conversation
Contributor
size-limit report 📦
|
chargome
requested review from
a team,
Lms24,
logaretm and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/nextjs-16/tests/component-annotation.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
dev-packages/e2e-tests/test-applications/nextjs-16/tests/component-annotation.test.ts
Show resolved
Hide resolved
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
approved these changes
Mar 3, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice! Great that you found a way to bring this back to turbopack!
Had a concern about how we annotate but this shouldn't hold us back from shipping the experimental option.
|
|
||
| const callback = this.async() ?? this.callback; | ||
|
|
||
| const hooks = createComponentNameAnnotateHooks(ignoredComponents, false); |
Member
There was a problem hiding this comment.
Q: I guess with loaders we can only use the component-based plugin and have to set injectIntoHtml to false, correct?
Member
Author
There was a problem hiding this comment.
I think we could actually use both but went with the lower html impact – safer default imo
chargome
deleted the
cg/JS-1709/nextjs-turbopack-react-component-annotation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Turbopack loader that annotates React components with
data-sentry-component,data-sentry-element, anddata-sentry-source-fileattributes at build time. This enables searching Replays by component name, seeing component names in breadcrumbs, and performance monitoring — previously only available with webpack builds.componentAnnotationLoaderthat reusescreateComponentNameAnnotateHooksfrom@sentry/bundler-plugin-coreconstructTurbopackConfigfor*.{tsx,jsx}files with condition:{ not: 'foreign' }(Next.js 16+ only)_experimental.turbopackReactComponentAnnotationin SentryBuildOptionsUsage
closes #19319