Add supportsViewTransition host config flag#35965
Open
zeyap wants to merge 1 commit intofacebook:mainfrom
Open
Add supportsViewTransition host config flag#35965zeyap wants to merge 1 commit intofacebook:mainfrom
zeyap wants to merge 1 commit intofacebook:mainfrom
Conversation
zeyap
force-pushed
the
supportsViewTransition
branch
from
d612573 to
740940d
Compare
rickhanlonii
reviewed
Mar 5, 2026
| @@ -413,6 +413,7 @@ export const isPrimaryRenderer = false; | |||
| export const warnsIfNotActing = false; | |||
|
|
|||
| export const supportsMutation = true; | |||
| export const supportsViewTransition = false; | |||
Member
There was a problem hiding this comment.
instead this should add this below:
export * from 'react-reconciler/src/ReactFiberConfigWithNoViewTransition';
Member
There was a problem hiding this comment.
Same for everywhere else it's being set in the other fiber configs
…n out of ReactFiberConfigWithNoMutation
zeyap
force-pushed
the
supportsViewTransition
branch
from
740940d to
db2eee7
Compare
rickhanlonii
reviewed
Mar 5, 2026
| @@ -139,7 +139,7 @@ function applyViewTransitionToHostInstancesRecursive( | |||
| collectMeasurements: null | Array<InstanceMeasurement>, | |||
| stopAtNestedViewTransitions: boolean, | |||
| ): boolean { | |||
| if (!supportsMutation) { | |||
| if (!supportsViewTransition) { | |||
Member
There was a problem hiding this comment.
sus, i don't know if this makes sense. need to think about this more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportsViewTransitionhost config flag (likesupportsMutation,supportsHydration) so the reconciler can check renderer capability directlyReactFiberConfigWithNoMutation.jsinto a newReactFiberConfigWithNoViewTransition.js!supportsMutation && !supportsPersistencechecks in the reconciler with!supportsViewTransitionsupportsViewTransition = truefor DOM and Fabric renderers,falsefor Native (paper), ART, and test-rendererTest plan
yarn flowfor dom-node, fabric, native renderers