Conversation
JohnSwan1503
approved these changes
Mar 6, 2026
This was referenced Mar 6, 2026
Theodus
force-pushed
the
theodus/compaction-wip
branch
from
62342d9 to
7927b42
Compare
The predicate for Live files was returning `*size_exceeded` which meant files could only join a group when combined size ALREADY exceeded the target. Since two small files can never exceed 512 MiB, no groups were ever formed in "Strict Eager Compaction" mode (when eager_compaction_limit >= target_partition_size). Changed to `!*size_exceeded` to match Cold file behavior: files can join a group as long as combined size does NOT exceed the target. This allows accumulating many small files until they reach the target size. Signed-off-by: Theo Butler <theodusbutler@gmail.com>
Signed-off-by: Theo Butler <theodusbutler@gmail.com>
Signed-off-by: Theo Butler <theodusbutler@gmail.com>
Theodus
force-pushed
the
theodus/compaction-wip
branch
from
7927b42 to
b8b8a69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a proposal to simplify the compaction algorithm into essentially:
Generation-based compaction for files under cooldown is removed. Eager compaction configuration for recent files is simplified to be purely generation based, replacing the more complex
eager_compaction_limit.Replaces #1417, #1913