feat: Rely on the network launcher to report whether friendly domains are supported#412
Open
adamspofford-dfinity wants to merge 3 commits intomainfrom
Open
feat: Rely on the network launcher to report whether friendly domains are supported#412adamspofford-dfinity wants to merge 3 commits intomainfrom
adamspofford-dfinity wants to merge 3 commits intomainfrom
Conversation
lwshang
requested changes
Mar 5, 2026
| root_key: local_root_key.clone(), | ||
| api_url: Url::parse("http://localhost:8000").unwrap(), | ||
| http_gateway_url: None, | ||
| use_friendly_domains: false, |
Contributor
There was a problem hiding this comment.
The test changes only add use_friendly_domains: false to existing constructors. There's no test that exercises the true path to verify friendly domain URLs are actually printed in print_canister_urls.
| use_friendly_domains: launcher_status | ||
| .supported_features | ||
| .iter() | ||
| .any(|f| f == "custom-domains"), |
Contributor
There was a problem hiding this comment.
The feature name "custom-domains" appears as a raw string in both docker.rs and launcher.rs. Consider extracting to a constant to avoid typo-related bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.