Skip to content

Let completion-key bindings be configurable#1676

Open
rolandwalker wants to merge 1 commit intomainfrom
RW/completion-key-bindings
Open

Let completion-key bindings be configurable#1676
rolandwalker wants to merge 1 commit intomainfrom
RW/completion-key-bindings

Conversation

@rolandwalker
Copy link
Contributor

Description

Let completion-key bindings be configurable, but set to the current behaviors by default.

There are several behaviors, some of which are mutually exclusive. It would be complex to lay out in the options which are exclusive, so that is just documented in the commentary.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Mar 5, 2026
@rolandwalker rolandwalker force-pushed the RW/completion-key-bindings branch from 58c4c73 to c3c3f73 Compare March 5, 2026 10:27
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

  1. Correctness regression: single-value config is parsed as str, causing wrong behavior matching

  2. Missing tests for new configurable behavior paths

    • The PR changes runtime key behavior but adds no behavioral tests, only config template updates.
    • Action: add tests covering at least:
      • single-value config (tab = advancing_summon, tab = prefixing_summon, control_space = advancing_summon)
      • default multi-value config
      • toggle behavior when completion menu is open.

Security review: no new security concerns identified in this diff.

@rolandwalker rolandwalker force-pushed the RW/completion-key-bindings branch from c3c3f73 to 6876a17 Compare March 5, 2026 10:39
but set to the current behaviors by default.

There are several behaviors, some of which are mutually exclusive.  It
would be complex to lay out in the options which are exclusive, so that
is just documented in the commentary.
@rolandwalker rolandwalker force-pushed the RW/completion-key-bindings branch from 6876a17 to 5283e5e Compare March 5, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant