json stringify: nested interfaces, llvm-type resolution, member_access dispatch#99
Merged
json stringify: nested interfaces, llvm-type resolution, member_access dispatch#99
Conversation
f8b1161 to
6540f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json stringify: nested interfaces, llvm-type resolution, member_access dispatch
Summary
Three gaps in
JSON.stringifydispatch that caused silent wrong output or compile errors:emitAddFieldsToJsonObjpreviously loaded any non-string/non-boolean field asdouble, which is wrong for nested interface-typed fields (stored asi8*). Now detects nested interfaces viainterfaceStructGenHasInterfaceand recursively builds a sub-object usingcsyyjson_obj_add_obj.resolveInterfaceTypeonly checked the symbol table by variable name. Variables populated fromJSON.parse<T>()have their type in the LLVM type map (%T*) but not always insymbolTable.getInterfaceType. Now falls back to extracting the interface name from the LLVM type string, enablingJSON.stringify(cfg)wherecfg = JSON.parse<Config>(str).member_accessdispatch:JSON.stringify(user.address)whereaddress: Addresspreviously fell through to an error. Now resolves the field's TS type by walking the parent interface's struct layout.Test plan
json stringify nested interface fields— roundtripsPerson { name, age, address: Address { street, zip } }json stringify of a json parse result— parses, stringifies, re-parsesConfig { host, port, debug }npm run verify:quickpasses (Stage 0 + Stage 1 self-hosting + full unit tests)