Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: run unit tests in CI, smarter test.js setup checks
Summary
compiler.test.tsand unit tests were never run in CI — only self-hosting and examples were. A broken unit test would pass CI.npm testunconditionally rebuilt the entire compiler every run, even when nothing had changed.Changes
ci.yml: addnpm teststep (10min timeout) to bothbuild-linux-glibcandbuild-macosjobs, after native chad is built and before examples/self-hostingscripts/test.js: replace always-rebuild with staleness checks — only rebuildsdist/ifsrc/**/*.tsis newer, only builds.build/chadif missing; fails fast with a clear error + fix command if vendor artifacts are missingTest plan
npm testskips rebuild whendist/is freshnpm testfails immediately with a clear message if vendor artifacts are missing