Open
Conversation
4c8770f to
32f3170
Compare
5b273db to
9bd01d3
Compare
Dany9966
requested changes
Mar 2, 2026
coriolis/osmorphing/windows.py
Outdated
| if (!(Test-Path $targetPath)) { New-Item -ItemType Directory -Force -Path $targetPath | Out-Null } | ||
| } else { | ||
| $parentPath = Split-Path $targetPath | ||
| if (!(Test-Path $parentPath)) { New-Item -ItemType Directory -Force -Path $parentPath | Out-Null } |
Contributor
There was a problem hiding this comment.
I think you should handle dir creation in a separate if statement, so you don't pass dir creation code twice:
for item in entries:
target_path = path.combine(destination, item.fullname)
if isdir(target_path) and not test-path(target_path):
create_dir(target_path)
else:
extracttofile(entry, target_path, overwrite)9bd01d3 to
62c201a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow cloudbase-init to reboot when a restart is scheduled or in progress.