fix: remove flag_aliases to unbreak bazel 9#3649
fix: remove flag_aliases to unbreak bazel 9#3649rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a temporary workaround to address a critical compatibility issue with Bazel 9. By commenting out specific Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a build failure with Bazel 9 by temporarily disabling flag_alias calls in MODULE.bazel. The change comments out the problematic calls as a workaround for a bug in Bazel. My feedback focuses on improving the comment to ensure this temporary change is tracked and can be reverted easily in the future.
| # Temporarily comment out these flag aliases because they break Bazel 9 | ||
| # when transitions are also used with a target. |
There was a problem hiding this comment.
This comment provides good context. To make this temporary change easier to track and revert, consider adding a TODO with a reference to the issue. This helps ensure it's addressed once the underlying Bazel bug is fixed.
| # Temporarily comment out these flag aliases because they break Bazel 9 | |
| # when transitions are also used with a target. | |
| # TODO(#3648): Uncomment when the Bazel 9 bug with flag_alias is fixed. | |
| # These are temporarily commented out to unbreak builds with transitions. |
The flag_alias() function in MODULE.bazel has a bug where it doesn't properly parse
labels when transitions are involved in certain ways (not entirely clear).
A fix will com in a later Bazel release. Until them, remove the calls.
Fixes #3648