ci: disable soft-fail jobs to unbreak ci#3647
ci: disable soft-fail jobs to unbreak ci#3647rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the CI pipeline where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request implements a temporary workaround for a critical CI pipeline failure by disabling the "ubuntu_rolling" job. The changes include clear inline comments explaining the reason for the disablement and provide a reference to the upstream issue, which is beneficial for future maintenance.
| # Temporarily remove this job to avoid all of CI failing | ||
| # Can be re-enabled after BazelCI is fixed, see | ||
| # http://github.com/bazelbuild/continuous-integration/pull/2487 |
There was a problem hiding this comment.
The comments clearly explain the temporary nature of this change. To further improve maintainability and ensure this temporary disablement is easily discoverable for future re-enablement, consider adding a TODO tag with a specific identifier (e.g., TODO(bazelci-bug)) to mark this as an item to revisit once the upstream issue is resolved. This makes it easier to track and search for such temporary workarounds.
# TODO(bazelci-bug): Re-enable this job after BazelCI is fixed.
# See http://github.com/bazelbuild/continuous-integration/pull/2487
# Temporarily removed to avoid all of CI failing.|
Looks like bazel ci fixed this; closing |
BazelCI has a bug where soft_fail jobs will break the entire CI pipeline.
Commenting them out seems to avoid the bug
See also: bazelbuild/continuous-integration#2487