Skip to content

ci: disable soft-fail jobs to unbreak ci#3647

Closed
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev:ci.remove.soft.fail
Closed

ci: disable soft-fail jobs to unbreak ci#3647
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev:ci.remove.soft.fail

Conversation

@rickeylev
Copy link
Collaborator

BazelCI has a bug where soft_fail jobs will break the entire CI pipeline.

Commenting them out seems to avoid the bug

See also: bazelbuild/continuous-integration#2487

@rickeylev rickeylev requested a review from aignas as a code owner March 5, 2026 06:32
@rickeylev rickeylev enabled auto-merge March 5, 2026 06:32
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in the CI pipeline where soft_fail jobs are causing complete CI failures. To restore stability and allow other checks to proceed, a specific soft_fail job has been temporarily disabled. This change is a workaround until the underlying BazelCI bug is resolved, as referenced in the comments.

Highlights

  • CI Stability: Temporarily disabled the ubuntu_rolling job in .bazelci/presubmit.yml to mitigate a BazelCI bug where soft_fail jobs cause the entire pipeline to fail.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .bazelci/presubmit.yml
    • The ubuntu_rolling job configuration was commented out.
    • Added comments explaining the temporary removal and linking to the upstream bug.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a temporary workaround for a critical CI pipeline failure by disabling the "ubuntu_rolling" job. The changes include clear inline comments explaining the reason for the disablement and provide a reference to the upstream issue, which is beneficial for future maintenance.

Comment on lines +197 to +199
# Temporarily remove this job to avoid all of CI failing
# Can be re-enabled after BazelCI is fixed, see
# http://github.com/bazelbuild/continuous-integration/pull/2487
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comments clearly explain the temporary nature of this change. To further improve maintainability and ensure this temporary disablement is easily discoverable for future re-enablement, consider adding a TODO tag with a specific identifier (e.g., TODO(bazelci-bug)) to mark this as an item to revisit once the upstream issue is resolved. This makes it easier to track and search for such temporary workarounds.

  # TODO(bazelci-bug): Re-enable this job after BazelCI is fixed.
  # See http://github.com/bazelbuild/continuous-integration/pull/2487
  # Temporarily removed to avoid all of CI failing.

@rickeylev
Copy link
Collaborator Author

Looks like bazel ci fixed this; closing

@rickeylev rickeylev closed this Mar 6, 2026
auto-merge was automatically disabled March 6, 2026 16:59

Pull request was closed

@rickeylev rickeylev deleted the ci.remove.soft.fail branch March 6, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant