Skip to content

backport: remove nonce and 7702 check (#1045)#1053

Closed
wlawt wants to merge 1 commit intoreleases/v0.5.2from
backport-no-nonce-7702-1
Closed

backport: remove nonce and 7702 check (#1045)#1053
wlawt wants to merge 1 commit intoreleases/v0.5.2from
backport-no-nonce-7702-1

Conversation

@wlawt
Copy link
Contributor

@wlawt wlawt commented Mar 5, 2026

No description provided.

@wlawt wlawt requested a review from niran March 5, 2026 00:40
@@ -8,8 +8,6 @@ use base_bundles::{BundleExtensions, BundleTxs, ParsedBundle, TransactionResult}
use eyre::{Result as EyreResult, eyre};
use op_revm::l1block::L1BlockInfo;
use reth_evm::{ConfigureEvm, execute::BlockBuilder};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation error: The imports for reth_optimism_chainspec::OpChainSpec and reth_optimism_evm::{OpEvmConfig, OpNextBlockEnvAttributes} were removed here, but these types are still used in this file:

  • OpChainSpec at the meter_bundle function signature (line 94)
  • OpNextBlockEnvAttributes at line 142
  • OpEvmConfig at line 167

These imports need to be restored.

@@ -2,23 +2,12 @@ use alloy_consensus::{Transaction, Typed2718, constants::KECCAK_EMPTY, transacti
use alloy_eips::Encodable2718;
use alloy_primitives::U256;
use derive_more::Display;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation error: The import use op_revm::{OpSpecId, l1block::L1BlockInfo}; was removed, but both types are still used in this file:

  • L1BlockInfo in the validate_tx signature (line 28) and in tests (lines 70-71)
  • OpSpecId::ISTHMUS at line 44 and line 128

This import needs to be restored.

@@ -2,23 +2,12 @@ use alloy_consensus::{Transaction, Typed2718, constants::KECCAK_EMPTY, transacti
use alloy_eips::Encodable2718;
use alloy_primitives::U256;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports: Typed2718 and KECCAK_EMPTY on line 1 (use alloy_consensus::{Transaction, Typed2718, constants::KECCAK_EMPTY, transaction::Recovered}) are no longer used after the removal of the interop and 7702 checks. With -D warnings in CI, these will cause compilation failures. This import should be simplified to:

use alloy_consensus::{Transaction, transaction::Recovered};

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Review Summary — backport: remove nonce and 7702 check (#1045)

Blocking: Compilation Errors (3 issues)

  1. meter.rs — Missing imports for OpChainSpec, OpEvmConfig, OpNextBlockEnvAttributes
    The PR removes use reth_optimism_chainspec::OpChainSpec and use reth_optimism_evm::{OpEvmConfig, OpNextBlockEnvAttributes} but these types are still used at lines 94, 142, and 167. These are not re-exported from any other imported crate.

  2. transaction.rs — Missing imports for OpSpecId and L1BlockInfo
    The PR removes use op_revm::{OpSpecId, l1block::L1BlockInfo} but both types are still used: L1BlockInfo in the function signature (line 28) and tests (lines 70-71), OpSpecId::ISTHMUS at lines 44 and 128.

  3. transaction.rs — Unused imports Typed2718 and KECCAK_EMPTY
    These were used by the removed interop and 7702 checks. With -D warnings in CI clippy, these will fail the build.

Blocking: Test Will Fail

  1. meter.rs:688meter_bundle_err_interop_tx test expects removed validation
    This test asserts that an interop transaction returns "Interop transactions are not supported", but the interop check was removed from validate_tx. The test needs to be removed or updated to reflect the new behavior.

Summary

The intent of removing nonce, 7702, and interop checks from validate_tx is clear, but the PR has incomplete cleanup: imports were removed that are still needed, imports that are no longer needed were kept, and a test in meter.rs that depends on the removed interop check was not updated.

niran added a commit that referenced this pull request Mar 5, 2026
Resolve conflicts between the two backport PRs and fix #1053's
broken imports (base_alloy_consensus, base_alloy_network,
base_node_runner don't exist on releases/v0.5.2). Remove
meter_bundle_err_interop_tx test since #1053 removed the interop
check from validate_tx.
@niran
Copy link
Contributor

niran commented Mar 5, 2026

  1. Missing op_revm import in transaction.rs — the PR removes the use op_revm::{OpSpecId, l1block::L1BlockInfo}; import, but validate_tx still uses both L1BlockInfo and OpSpecId. Doesn't compile.

  2. Wrong crate names in test imports — the test module references base_alloy_consensus, base_alloy_network, and base_node_runner, which are main-branch renames. On releases/v0.5.2 these are still op_alloy_consensus, op_alloy_network, and base_client_node.

I hit these while merging both backports into a combined test branch (test/v0.5.2-combined-backports).

@wlawt wlawt closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants