backport: remove nonce and 7702 check (#1045)#1053
backport: remove nonce and 7702 check (#1045)#1053wlawt wants to merge 1 commit intoreleases/v0.5.2from
Conversation
| @@ -8,8 +8,6 @@ use base_bundles::{BundleExtensions, BundleTxs, ParsedBundle, TransactionResult} | |||
| use eyre::{Result as EyreResult, eyre}; | |||
| use op_revm::l1block::L1BlockInfo; | |||
| use reth_evm::{ConfigureEvm, execute::BlockBuilder}; | |||
There was a problem hiding this comment.
Compilation error: The imports for reth_optimism_chainspec::OpChainSpec and reth_optimism_evm::{OpEvmConfig, OpNextBlockEnvAttributes} were removed here, but these types are still used in this file:
OpChainSpecat themeter_bundlefunction signature (line 94)OpNextBlockEnvAttributesat line 142OpEvmConfigat line 167
These imports need to be restored.
| @@ -2,23 +2,12 @@ use alloy_consensus::{Transaction, Typed2718, constants::KECCAK_EMPTY, transacti | |||
| use alloy_eips::Encodable2718; | |||
| use alloy_primitives::U256; | |||
| use derive_more::Display; | |||
There was a problem hiding this comment.
Compilation error: The import use op_revm::{OpSpecId, l1block::L1BlockInfo}; was removed, but both types are still used in this file:
L1BlockInfoin thevalidate_txsignature (line 28) and in tests (lines 70-71)OpSpecId::ISTHMUSat line 44 and line 128
This import needs to be restored.
| @@ -2,23 +2,12 @@ use alloy_consensus::{Transaction, Typed2718, constants::KECCAK_EMPTY, transacti | |||
| use alloy_eips::Encodable2718; | |||
| use alloy_primitives::U256; | |||
There was a problem hiding this comment.
Unused imports: Typed2718 and KECCAK_EMPTY on line 1 (use alloy_consensus::{Transaction, Typed2718, constants::KECCAK_EMPTY, transaction::Recovered}) are no longer used after the removal of the interop and 7702 checks. With -D warnings in CI, these will cause compilation failures. This import should be simplified to:
use alloy_consensus::{Transaction, transaction::Recovered};
Review Summary —
|
I hit these while merging both backports into a combined test branch ( |
No description provided.