HDDS-14659. Add new proto message for lightweight MultipartPartInfo#9867
Merged
devabhishekpal merged 8 commits intoapache:masterfrom Mar 7, 2026
Merged
HDDS-14659. Add new proto message for lightweight MultipartPartInfo#9867devabhishekpal merged 8 commits intoapache:masterfrom
devabhishekpal merged 8 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Mar 5, 2026
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @devabhishekpal for the patch.
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Mar 5, 2026
hadoop-ozone/interface-storage/src/main/proto/OmStorageProtocol.proto
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Mar 5, 2026
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @devabhishekpal for updating the patch, LGTM. Let's wait for others to take a look.
Contributor
Author
|
@ChenSammi @ivandika3 @errose28 could you take a look at this patch? |
ChenSammi
reviewed
Mar 6, 2026
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Mar 6, 2026
rakeshadr
reviewed
Mar 6, 2026
rakeshadr
approved these changes
Mar 7, 2026
Contributor
rakeshadr
left a comment
There was a problem hiding this comment.
Thanks @devabhishekpal with the contribution. +1 LGTM
ivandika3
approved these changes
Mar 7, 2026
Contributor
ivandika3
left a comment
There was a problem hiding this comment.
Thanks for the patch. LGTM +1.
Contributor
Author
|
Thanks for the reviews @adoroszlai @ivandika3 @ChenSammi @rakeshadr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-14659. Add new proto message for lightweight MutlipartPartInfo
Please describe your PR in detail:
MultipartPartInfo. This contains the absolutely essential fields required for any given part and drops any extra fields.MultipartKeyInfomessage to pull in common metadata fields likevolumeName,bucketName,keyName.schemaVersionwhich will help us with deciding whether to use a new flow for writing MPU parts, or use the currently approach of storing parts inline.Reference design doc: #9793
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14659
How was this patch tested?
Patch was tested via unit tests, but currently this change will not affect any behaviour.