[fix] Preserve CurrentConnected in frontends() TVF#61087
Open
deardeng wants to merge 2 commits intoapache:masterfrom
Open
[fix] Preserve CurrentConnected in frontends() TVF#61087deardeng wants to merge 2 commits intoapache:masterfrom
deardeng wants to merge 2 commits intoapache:masterfrom
Conversation
Cause: - FRONTENDS() goes through metadata scan and may be generated on master FE. - In this path, currentConnectedFE context is not always preserved, so CurrentConnected falls back to master and WHERE CURRENTCONNECTED='Yes' always matches master. Fix: - Reuse TFrontendsMetadataParams.cluster_name as a pass-through slot to carry the FE host that accepted the client connection from TVF planning to metadata generation. - Populate this host in FrontendsTableValuedFunction#getMetaScanRange (prefer ConnectContext.currentConnectedFEIp, fallback to self host). - Read and apply it in MetadataGenerator#frontendsMetadataResult via FrontendsProcNode#getFrontendsInfo(env, infos, currentConnectedFeHost). - Add comments at write/read points to explain why cluster_name is reused for this pass-through. Verification: - FE UT: org.apache.doris.tablefunction.FrontendsTableValuedFunctionTest
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27589 ms |
TPC-DS: Total hot run time: 153300 ms |
gavinchou
reviewed
Mar 5, 2026
fe/fe-core/src/main/java/org/apache/doris/tablefunction/FrontendsTableValuedFunction.java
Show resolved
Hide resolved
Background:\nFRONTENDS() previously reused TFrontendsMetadataParams.cluster_name to pass\nthe FE host that accepted the client connection. This made the semantics\nof cluster_name ambiguous and fragile.\n\nFix:\n- add optional field current_connected_fe_host to TFrontendsMetadataParams\n- write this field in FrontendsTableValuedFunction\n- read this field in MetadataGenerator when building FRONTENDS() rows\n- update FrontendsTableValuedFunctionTest assertions\n\nCompatibility:\ncluster_name remains unchanged for compatibility; CurrentConnected now uses\na dedicated field with explicit meaning.
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 27744 ms |
TPC-DS: Total hot run time: 153463 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause:
Fix:
Verification:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)