Skip to content

Fix #15760: Convert undo/redo labels to sentence case#20372

Open
flowerjunjie wants to merge 1 commit intoankidroid:mainfrom
flowerjunjie:fix/issue-15760
Open

Fix #15760: Convert undo/redo labels to sentence case#20372
flowerjunjie wants to merge 1 commit intoankidroid:mainfrom
flowerjunjie:fix/issue-15760

Conversation

@flowerjunjie
Copy link

This PR implements sentence case conversion for undo/redo labels to maintain consistency with the rest of the UI, as requested in #15760.

Changes

  • Added 120+ sentence case string resources for undo/redo actions
  • Created helper functions in SentenceCase.kt for undo/redo label conversion
  • Updated ReviewerViewModel.kt, Undo.kt, CardBrowser.kt, DeckPicker.kt, Reviewer.kt, StudyOptionsActivity.kt

Examples

Before After
Undo Empty Cards Undo empty cards
Empty Cards undone Empty cards undone

Fixes #15760

This commit implements sentence case conversion for undo/redo labels
to maintain consistency with the rest of the UI.

Changes:
- Added 120+ sentence case string resources for undo/redo actions
- Created helper functions in SentenceCase.kt for undo/redo label conversion
- Updated ReviewerViewModel.kt to convert undo/redo labels to sentence case
- Updated Undo.kt to convert undo/redo messages to sentence case
- Updated CardBrowser.kt, DeckPicker.kt, Reviewer.kt, StudyOptionsActivity.kt
to use sentence case for undo labels

The conversion handles patterns like:
- "Undo Empty Cards" → "Undo empty cards"
- "Empty Cards undone" → "Empty cards undone"
- "Redo Empty Cards" → "Redo empty cards"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Inconsistent String Casing

1 participant