Skip to content

feat(ng-dev): add rules_* repositories to ManagedRepositories#3488

Merged
josephperrott merged 1 commit intoangular:mainfrom
josephperrott:update-org-sync
Mar 5, 2026
Merged

feat(ng-dev): add rules_* repositories to ManagedRepositories#3488
josephperrott merged 1 commit intoangular:mainfrom
josephperrott:update-org-sync

Conversation

@josephperrott
Copy link
Member

Includes rules_angular, rules_browsers, and rules_sass in the ManagedRepositories enum and default label repositories.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2026
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 5, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds rules_angular, rules_browsers, and rules_sass to the ManagedRepositories enum and to the default list of repositories for labels. The change is straightforward. I've left one comment regarding sorting the new enum members for better code maintainability.

Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names are wrong.

Includes rules_angular, rules_browsers, and rules_sass in the ManagedRepositories enum and default label repositories.
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 1e1aced into angular:main Mar 5, 2026
9 checks passed
@josephperrott
Copy link
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@josephperrott josephperrott deleted the update-org-sync branch March 5, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants