build: update dependency aspect_rules_js to v3 - autoclosed#3483
build: update dependency aspect_rules_js to v3 - autoclosed#3483angular-robot wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the aspect_rules_js dependency to version 3.0.1, which is a major version upgrade. The extensive changes in MODULE.bazel.lock are expected as they reflect the updates to transitive dependencies and internal changes in aspect_rules_js v3. My main feedback is that this upgrade makes some existing configuration in MODULE.bazel obsolete. I've added a comment to address this for code cleanup and maintainability.
MODULE.bazel
Outdated
| bazel_dep(name = "aspect_bazel_lib", version = "2.22.5") | ||
| bazel_dep(name = "bazel_skylib", version = "1.9.0") | ||
| bazel_dep(name = "aspect_rules_js", version = "2.9.2") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.0.1") |
There was a problem hiding this comment.
With the upgrade to aspect_rules_js v3, the pnpm.pnpm module extension is no longer necessary. The npm_translate_lock extension now handles fetching pnpm internally.
The corresponding pnpm.pnpm call in MODULE.bazel (lines 79-85) is now obsolete and should be removed as part of this PR to avoid dead code and potential confusion.
josephperrott
removed
the
action: merge
angular-robot
force-pushed
the
ng-renovate/major-bazel-dependencies
branch
from
db375c7 to
04af834
Compare
See associated pull request for more information.
angular-robot
force-pushed
the
ng-renovate/major-bazel-dependencies
branch
from
04af834 to
ef98d35
Compare
angular-robot
changed the title
2 participants
This PR contains the following updates:
2.9.2→3.0.2