Skip to content

perf(@angular/cli): avoid redundant package version resolution in ng add #32715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydin wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −6
Open

perf(@angular/cli): avoid redundant package version resolution in ng add #32715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions packages/angular/cli/src/commands/add/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,9 @@ export default class AddCommandModule

let manifest;
try {
manifest = await this.context.packageManager.getManifest(
context.packageIdentifier.toString(),
{
registry,
},
);
manifest = await this.context.packageManager.getManifest(context.packageIdentifier, {
registry,
});
} catch (e) {
assertIsError(e);
throw new CommandError(
Expand All @@ -508,6 +505,17 @@ export default class AddCommandModule
);
}

// Avoid fully resolving the package version from the registry again in later steps
if (context.packageIdentifier.registry) {
assert(context.packageIdentifier.name, 'Registry package identifier must have a name');
context.packageIdentifier = npa.resolve(
context.packageIdentifier.name,
// `save-prefix` option is ignored by some package managers so the caret is needed to ensure
// that the value in the project package.json is correct.
'^' + manifest.version,
);
}

context.hasSchematics = !!manifest.schematics;
context.savePackage = manifest['ng-add']?.save;
context.collectionName = manifest.name;
Expand Down