fix(@angular/build): allow any CHROME_BIN for vitest playwright provider#32699
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 5, 2026
Merged
fix(@angular/build): allow any CHROME_BIN for vitest playwright provider#32699alan-agius4 merged 1 commit intoangular:mainfrom
CHROME_BIN for vitest playwright provider#32699alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
…vider The Playwright browser provider in Vitest now uses the `CHROME_BIN` environment variable as the executable path if it's set, removing the restriction that it must contain 'rules_browsers'. This is useful in CI environments to ensure a specific browser binary is used for testing in CI. Closes angular#32697
alan-agius4
force-pushed
the
executablePath
branch
from
9b63e35 to
8892ccf
Compare
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the logic for configuring the Playwright browser provider in Vitest by removing the rules_browsers restriction on CHROME_BIN. The change is well-implemented and makes the code cleaner. My only feedback is to add unit tests to cover this new behavior to prevent future regressions.
clydin
approved these changes
Mar 5, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Playwright browser provider in Vitest now uses the
CHROME_BINenvironment variable as the executable path if it's set, removing the restriction that it must contain 'rules_browsers'.This is useful in CI environments to ensure a specific browser binary is used for testing in CI.
Closes #32697