Skip to content

build: update cross-repo angular dependencies#32694

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:pr-takeover-32681
Mar 5, 2026
Merged

build: update cross-repo angular dependencies#32694
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:pr-takeover-32681

Conversation

@alan-agius4
Copy link
Collaborator

See associated pull request for more information.

Closes #32681 as a pr takeover

@alan-agius4 alan-agius4 requested a review from clydin March 5, 2026 08:48
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Mar 5, 2026
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 5, 2026
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Mar 5, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various Angular dependencies across the repository, primarily to move to version 22. The changes involve bumping versions in package.json files, constants.bzl, and MODULE.bazel, with corresponding updates to pnpm-lock.yaml. My review focused on the consistency of these version updates. I found one potential issue in constants.bzl where a peer dependency version for ng-packagr appears to have been missed during the update to version 22. Otherwise, the dependency updates look correct and consistent with the goal of the pull request.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various Angular-related dependencies across the repository. The changes include updating commit hashes for Bazel modules, bumping version constants for Angular framework and ng-packagr, and updating devDependencies and peerDependencies in several package.json files. The lockfile (pnpm-lock.yaml) has been updated accordingly to reflect these changes. The updates are consistent and appear to be a standard dependency bump.

@alan-agius4 alan-agius4 force-pushed the pr-takeover-32681 branch 2 times, most recently from e12882c to beffd21 Compare March 5, 2026 15:29
See associated pull request for more information.

Closes angular#32681 as a pr takeover
@alan-agius4 alan-agius4 requested a review from dgp1130 March 5, 2026 19:20
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 5, 2026
@alan-agius4 alan-agius4 removed the request for review from clydin March 5, 2026 19:22
@alan-agius4 alan-agius4 merged commit 097267a into angular:main Mar 5, 2026
81 of 86 checks passed
@alan-agius4
Copy link
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the pr-takeover-32681 branch March 5, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants